From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/tui] Fix displaying main after resizing
Date: Fri, 24 Nov 2023 20:43:02 -0700 [thread overview]
Message-ID: <87cyvyxzuh.fsf@tromey.com> (raw)
In-Reply-To: <20231124085902.24318-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 24 Nov 2023 09:59:02 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Fix this by moving a call to tui_display_main from tui_enable to
Tom> tui_apply_current_layout.
Tom> - tui_update_source_windows_with_addr (gdbarch, addr);
Tom> + if (addr == 0)
Tom> + tui_display_main ();
Tom> + else
Tom> + tui_update_source_windows_with_addr (gdbarch, addr);
This 'if' seems like something the source window ought to know, not the
layout code.
But between this and the register window patch in the same spot, I
wonder if there's some more generic solution available. Like, if I
write a TUI window in Python, will redoing the layout cause a refresh?
If not -- isn't that a bug? Or if so -- why can't built-in windows work
the same way?
Tom
next prev parent reply other threads:[~2023-11-25 3:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 8:59 Tom de Vries
2023-11-25 3:43 ` Tom Tromey [this message]
2023-11-25 9:44 ` Tom de Vries
2023-12-08 15:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyvyxzuh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).