From: Tom Tromey <tom@tromey.com>
To: Mark Wielaard <mark@klomp.org>
Cc: gdb-patches@sourceware.org, Simon Marchi <simark@simark.ca>
Subject: Re: [PATCHv2] xcoffread.c: Fix -Werror=dangling-pointer= issue with main_subfile.
Date: Tue, 02 May 2023 09:12:55 -0600 [thread overview]
Message-ID: <87cz3ivkaw.fsf@tromey.com> (raw)
In-Reply-To: <20230501181948.1407024-1-mark@klomp.org> (Mark Wielaard's message of "Mon, 1 May 2023 20:19:49 +0200")
>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
Mark> GCC 13 points out that main_subfile has local function scope, but a
Mark> pointer to it is assigned to the global inclTable array subfile
Mark> element field:
Thanks, Mark. This is ok.
All this code seems very bit-rotted to me. Like, it seems to me that it
doesn't even properly handle multiple objfiles, a genuinely ancient
addition to gdb. I wonder whether it could be removed.
Tom
prev parent reply other threads:[~2023-05-02 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 21:13 [PATCH] " Mark Wielaard
2023-05-01 13:53 ` Simon Marchi
2023-05-01 18:14 ` Mark Wielaard
2023-05-01 18:19 ` [PATCHv2] " Mark Wielaard
2023-05-02 15:12 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz3ivkaw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).