Re: [PATCH] gdb: add 'maintenance print record-instruction' command

[Tom Tromey <tom@tromey.com>]

>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:

Bruno> While chasing some reverse debugging bugs, I found myself wondering what
Bruno> was recorded by GDB to undo and redo a certain instruction. This commit
Bruno> implements a simple way of printing that information.

Thanks.  The idea seems fine to me.

Bruno> +	      gdb_byte* b = record_full_get_loc (to_print);

The "* " should be " *", there's a few of these.

Bruno> +		gdb_printf (" %02x",b[i]);

Missing a space after the ",", also a few of these.

Bruno> +  add_cmd ("record-instruction", class_maintenance,
Bruno> +	   maintenance_print_record_instruction,
Bruno> +	   _("\
Bruno> +Print a recorded instruction.\nIf no argument is provided, print the last \
Bruno> +instruction recorded.\nIf a negative argument is given, prints how the nth \
Bruno> +previous instruction will be undone.\nIf a positive argument is given, prints \
Bruno> +how the nth following instruction will be redone."), &maintenanceprintlist);

IMO it's better to end the lines with \n\ so that the line breaks are
very clear when reading the text in the source.

Tom