Re: [PATCH 8/8] gdb/aarch64: When remote debugging detect changes in the target description

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Luis Machado <luis.machado@arm.com> writes:

> On 9/8/22 07:41, Thiago Jung Bauermann via Gdb-patches wrote:
>> If the remote target provides an expedited VG register, use it to update
>> its target description.  This allows debugging programs that change their
>> SVE vector length during runtime.
>> This is accomplished by implementing the thread_architecture method in
>> remote_target, which returns the gdbarch corresponding to the expedited
>> registers provided by the last stop reply.
>> To allow changing the architecture based on the expedited registers, add a
>> new gdbarch method to allow arch-specific code to make the adjustment.
>> ---
>>   gdb/aarch64-tdep.c        | 28 +++++++++++++++++++++++++-
>>   gdb/arch-utils.c          |  9 +++++++++
>>   gdb/arch-utils.h          |  5 +++++
>>   gdb/gdbarch-components.py | 16 +++++++++++++++
>>   gdb/gdbarch-gen.h         | 11 ++++++++++
>>   gdb/gdbarch.c             | 23 +++++++++++++++++++++
>>   gdb/remote.c              | 42 +++++++++++++++++++++++++++++++++++++++
>>   7 files changed, 133 insertions(+), 1 deletion(-)
>
> LGTM for the aarch64 code. Someone else must approve the generic parts.

Thank you again for your review. For v2 I changed the patch title and
description a little bit, but the code is the same.

-- 
Thiago