Re: [PATCH 1/2] gdb: check for empty offsets vector in inherit_abstract_dies

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> +  if (!offsets.empty ())
Simon> +    {
Simon> +      std::sort (offsets.begin (), offsets.end ());
Simon> +      sect_offset *offsets_end = offsets.data () + offsets.size ();
Simon> +      for (sect_offset *offsetp = offsets.data () + 1;
Simon> +	   offsetp < offsets_end;
Simon> +	   offsetp++)
Simon> +	if (offsetp[-1] == *offsetp)
Simon> +	  complaint (_("Multiple children of DIE %s refer "
Simon> +		       "to DIE %s as their abstract origin"),
Simon> +		     sect_offset_str (die->sect_off),
Simon> +		     sect_offset_str (*offsetp));
Simon> +    }
 
Simon>    sect_offset *offsetp = offsets.data ();
Simon> +  sect_offset *offsets_end = offsets.data () + offsets.size ();
Simon>    die_info *origin_child_die = origin_die->child;
Simon>    while (origin_child_die != nullptr && origin_child_die->tag != 0)
Simon>      {

This subsequent loop does stuff like:

      while (offsetp < offsets_end
	     && *offsetp < origin_child_die->sect_off)
	offsetp++;

which in this scenario would be comparing null pointers using "<"?

I'm guessing this whole loop should be hoisted into the 'if'.

Tom