From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH][gdb] Fix heap-buffer-overflow in find_program_interpreter
Date: Fri, 14 Oct 2022 11:56:38 -0600 [thread overview]
Message-ID: <87czaumgq1.fsf@tromey.com> (raw)
In-Reply-To: <20221012154131.GA24693@delia.home> (Tom de Vries via Gdb-patches's message of "Wed, 12 Oct 2022 17:41:33 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> The problem originates in find_program_interpreter, where
Tom> bfd_get_section_contents is called to read .interp, but fails. The function
Tom> returns false but the result is ignored, so find_program_interpreter returns
Tom> some random string.
Tom> Fix this by checking the result of the call to bfd_get_section_contents.
Tom> Tested on x86_64-linux.
Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29652
Tom> Any comments?
Looks good, thank you.
Tom
prev parent reply other threads:[~2022-10-14 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:41 Tom de Vries
2022-10-14 17:56 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czaumgq1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).