From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
Cc: Lancelot SIX <lancelot.six@amd.com>, lsix@lancelotsix.com
Subject: Re: [PATCH] gdb: Only paginate for filtered output in fputs_maybe_filtered
Date: Thu, 17 Feb 2022 16:59:08 -0700 [thread overview]
Message-ID: <87czjloxir.fsf@tromey.com> (raw)
In-Reply-To: <20220217111904.3623848-1-lancelot.six@amd.com> (Lancelot SIX via Gdb-patches's message of "Thu, 17 Feb 2022 11:19:04 +0000")
>>>>> ">" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
>> The filter parameter is correctly used to guard the first place where
>> prompt_for_continue. There is a second place in the function which can call
>> prompt_for_continue, but is currently unguarded. I believe that this is an
>> oversight, this patch fixes that.
Thanks, this is ok.
It's perhaps worth noting that I believe this is also fixed by my series
to change the filter to be a more ordinary ui_file.
Tom
next prev parent reply other threads:[~2022-02-17 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 11:19 Lancelot SIX
2022-02-17 23:59 ` Tom Tromey [this message]
2022-02-18 9:18 ` Lancelot SIX
2022-02-20 18:34 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czjloxir.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).