From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Aditya Kamath1 <Aditya.Kamath1@ibm.com>,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
Aditya Kamath1 via Gdb-patches <gdb-patches@sourceware.org>,
Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: Re: Fix max-depth test case for AIX.
Date: Wed, 03 Apr 2024 08:58:18 -0600 [thread overview]
Message-ID: <87edbm8pdh.fsf@tromey.com> (raw)
In-Reply-To: <87wmpe355n.fsf@redhat.com> (Andrew Burgess's message of "Wed, 03 Apr 2024 15:13:56 +0100")
Andrew> Given what the test is doing I don't think there's any need for the
Andrew> #ifdef, I'd suggest just adding a comment explaining why we need to
Andrew> ensure the variables are referenced, and reference them.
Agreed. Look for 'Do_Nothing' in the Ada tests to see how this is
handled for Ada programs. I feel like we've done something similar in
some cases for C as well.
Tom
next prev parent reply other threads:[~2024-04-03 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 9:00 Aditya Kamath1
2024-04-03 14:13 ` Andrew Burgess
2024-04-03 14:58 ` Tom Tromey [this message]
2024-04-10 6:01 ` Aditya Kamath1
2024-04-16 17:24 ` Tom Tromey
2024-04-17 10:40 ` Aditya Kamath1
2024-04-17 10:44 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edbm8pdh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).