RE: Fix max-depth test case for AIX.

[Aditya Kamath1 <Aditya.Kamath1@ibm.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1269 bytes --]

Respected community members,

Hi,

>This is ok.
>Approved-By: Tom Tromey tom@tromey.com<mailto:tom@tromey.com>

Thank you Tom.

Can someone kindly commit this patch. Attaching it again. I do not have the access to do the same.

Have a nice day ahead.

Thanks and regards,
Aditya.




From: Tom Tromey <tom@tromey.com>
Date: Tuesday, 16 April 2024 at 10:54 PM
To: Aditya Kamath1 <Aditya.Kamath1@ibm.com>
Cc: Tom Tromey <tom@tromey.com>, Andrew Burgess <aburgess@redhat.com>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, Aditya Kamath1 via Gdb-patches <gdb-patches@sourceware.org>, Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: Fix max-depth test case for AIX.
>>>>> Aditya Kamath1 <Aditya.Kamath1@ibm.com> writes:

> From 3117e666bad264e460596903acbcd008dc3f9287 Mon Sep 17 00:00:00 2001
> From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>
> Date: Wed, 10 Apr 2024 00:52:05 -0500
> Subject: [PATCH] Fix max-depth test case for AIX.

> In AIX, if in the main program the global variables are unused then the linker optimises
> these variables and the dwarf will not have proper address to the same. Hence we cannot access these
> variables.

This is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

[-- Attachment #2: 0001-Fix-max-depth-test-case-for-AIX.patch --]
[-- Type: application/octet-stream, Size: 1223 bytes --]

From 3117e666bad264e460596903acbcd008dc3f9287 Mon Sep 17 00:00:00 2001
From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>
Date: Wed, 10 Apr 2024 00:52:05 -0500
Subject: [PATCH] Fix max-depth test case for AIX.

In AIX, if in the main program the global variables are unused then the linker optimises
these variables and the dwarf will not have proper address to the same. Hence we cannot access these
variables.

This patch is a fix to the same so that all the test case of max-depth can passs in AIX as well.
---
 gdb/testsuite/gdb.base/max-depth.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gdb/testsuite/gdb.base/max-depth.c b/gdb/testsuite/gdb.base/max-depth.c
index fee5de5af34..7e46b134c10 100644
--- a/gdb/testsuite/gdb.base/max-depth.c
+++ b/gdb/testsuite/gdb.base/max-depth.c
@@ -225,8 +225,17 @@ struct V7 : virtual V4, virtual V5, virtual V6 { int v7 = 1; } v7;
 
 #endif /* __cplusplus */
 
+void Do_nothing (struct s1 sone)
+{
+  /*  This Function does nothing.  */
+}
+
 int
 main ()
 {
+  /*  In targets like AIX, linker optimises out unused global
+      variables.  The do_nothing () function stops the linker
+      from doing so.  */
+  Do_nothing (s1);
   return 0;
 }
-- 
2.41.0