From: Tom Tromey <tom@tromey.com>
To: "Six, Lancelot" <Lancelot.Six@amd.com>
Cc: Tom Tromey <tom@tromey.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: ensure has dwarf info before reading DWZ file
Date: Tue, 02 Apr 2024 07:16:12 -0600 [thread overview]
Message-ID: <87edbnaorn.fsf@tromey.com> (raw)
In-Reply-To: <CH3PR12MB90797A801CB17D2695CCAD09833E2@CH3PR12MB9079.namprd12.prod.outlook.com> (Lancelot Six's message of "Tue, 2 Apr 2024 08:40:25 +0000")
> It can be called when doing "save gdb-index" (dwarf2/index-write.c:
> save_gdb_index_command). This case is exercised by
> "gdb.dwarf2/gdb-index-nodebug.exp".
> Maybe a better approach could be to modify save_gdb_index_command to
> check if there is any debug info before calling write_dwarf_index, but
> the current try/catch approach is the construct currently taking core
> of that. Having dwarf2_get_dwz_file return nullptr in that case does
> made sense to me, but I can also go another direction.
This seems fine, I don't think you need to change anything.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-04-02 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 11:01 Lancelot SIX
2024-04-01 16:09 ` Tom Tromey
2024-04-02 8:40 ` Six, Lancelot
2024-04-02 13:16 ` Tom Tromey [this message]
2024-04-03 12:55 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edbnaorn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).