From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX <lancelot.six@amd.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: ensure has dwarf info before reading DWZ file
Date: Mon, 01 Apr 2024 10:09:51 -0600 [thread overview]
Message-ID: <87y19x9i9c.fsf@tromey.com> (raw)
In-Reply-To: <20240330110121.2292510-1-lancelot.six@amd.com> (Lancelot SIX's message of "Sat, 30 Mar 2024 11:01:21 +0000")
>>>>> "Lancelot" == Lancelot SIX <lancelot.six@amd.com> writes:
Lancelot> A consequence of this change is that the per_bfd->dwz_file optional
Lancelot> object can now remain empty (instead of containing a nullptr), so also
Lancelot> this patch also adjusts dwarf2_get_dwz_file to account for this
Lancelot> possibility. This effectively reverts the changes to
Lancelot> dwarf2_get_dwz_file done by e9b738dfbdc.
I'm curious about the motivation for this change.
Can dwarf2_get_dwz_file be called when dwarf2_has_info returns false?
Tom
next prev parent reply other threads:[~2024-04-01 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 11:01 Lancelot SIX
2024-04-01 16:09 ` Tom Tromey [this message]
2024-04-02 8:40 ` Six, Lancelot
2024-04-02 13:16 ` Tom Tromey
2024-04-03 12:55 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y19x9i9c.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).