From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Handle core without build-id in gdb.base/corefile-buildid.exp
Date: Wed, 20 Mar 2024 11:17:21 -0600 [thread overview]
Message-ID: <87edc4g6vy.fsf@tromey.com> (raw)
In-Reply-To: <20240319073812.18995-1-tdevries@suse.de> (Tom de Vries's message of "Tue, 19 Mar 2024 08:38:12 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> The problem is that the test-case expect the build-id to be available in the
Tom> core file, while it isn't.
Tom> Fix this by detecting that the build-id isn't available in the core file using eu-readelf, as in
Tom> gdb.base/coredump-filter-build-id.exp.
I was kind of surprised to find that gdb's test suite depends on a
non-binutils program like this, but whatever, the dependency is already
there.
Anyway this seems fine to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2024-03-20 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 7:38 Tom de Vries
2024-03-20 17:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edc4g6vy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).