From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: Hannes Domani <ssbssa@yahoo.de>,
gdb-patches@sourceware.org, Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] Fix comparison of array types
Date: Mon, 18 Mar 2024 10:26:29 -0600 [thread overview]
Message-ID: <87edc7ik0a.fsf@tromey.com> (raw)
In-Reply-To: <4b9a274e-f072-4408-b797-857573a96b11@redhat.com> (Guinevere Larsen's message of "Thu, 29 Feb 2024 14:26:07 +0100")
>>>>> Guinevere Larsen <blarsen@redhat.com> writes:
> My one nitpick is that I think this code fits more naturally right
> after the pointer check, instead of the last check in the function,
> but feel free to disagree. Either way: Reviewed-By: Guinevere Larsen
> <blarsen@redhat.com>
This would make sense too, but I'm not sure how much it matters.
In most languages, array types don't have a name anyway.
Also I wonder if we really want to keep all these different
type-equality functions around. Right now there is types_equal,
types_deeply_equal, and also ada_type_match.
The Ada one is maybe hard to remove as long as GNAT encodings are
relevant. However maybe we could replace types_equal with
types_deeply_equal everywhere.
Tom
next prev parent reply other threads:[~2024-03-18 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240209194545.31497-1-ssbssa.ref@yahoo.de>
2024-02-09 19:45 ` Hannes Domani
2024-02-25 12:02 ` Hannes Domani
2024-02-29 13:26 ` Guinevere Larsen
2024-03-17 14:12 ` Hannes Domani
2024-03-18 16:26 ` Tom Tromey [this message]
2024-03-18 16:20 ` Tom Tromey
2024-03-20 15:46 ` Hannes Domani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edc7ik0a.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).