From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] [gdb/testsuite] Fix another fail and tcl error in gdb.dap/sources.exp
Date: Tue, 13 Feb 2024 11:08:45 -0700 [thread overview]
Message-ID: <87eddg5j9u.fsf@tromey.com> (raw)
In-Reply-To: <20240213161823.25945-1-tdevries@suse.de> (Tom de Vries's message of "Tue, 13 Feb 2024 17:18:23 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> These are the same type of tcl error and FAIL I just fixed for a later
Tom> request in the same test-case.
Tom> Fix this by:
Tom> - moving the wait-for-stop to before the loadedSources request to fix the
Tom> FAIL, and
Tom> - checking for $obj == "" to fix the tcl error.
This is fine as long as these tests are actually being run in the end.
What I mean is, it would be bad to cover up a real failure of some kind.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-02-13 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 16:18 Tom de Vries
2024-02-13 18:08 ` Tom Tromey [this message]
2024-02-14 8:56 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eddg5j9u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).