Re: [PATCH] [gdbserver] Fix overflow detection in gdbserver

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> +      if (count >= max_count || (static_cast<T>(-1) < 0
>> +&& count == (max_count - 1)
>> +&& firstdigit >= 0x8))
>> return -1;

Simon> I guess that the static_cast thing is to determine if the type is signed
Simon> or not?  Can you give it a name, for clarity, like (maybe there's a
Simon> better way, just an example):

Simon>   constexpr bool is_signed = static_cast<T> (-1) < 0;

We also have uses of std::is_signed<> and std::is_unsigned<> in the tree
already, so just using those is probably preferable, assuming this code
does what I think it does.

Tom