Re: [PATCH] gdbserver: Fix overflow detection in gdbserver

[Tom Tromey <tom@tromey.com>]

>>>>> "Kirill" == Kirill Radkin <kirill.radkin@syntacore.com> writes:

Thank you for the patch.
I didn't see a reply to this one.

Kirill> +template <typename T>
Kirill>  static int
Kirill> -require_int (char **pp, int *value)
Kirill> +require_int (char **pp, T *value)
Kirill>  {
Kirill> +  constexpr bool is_signed = std::is_signed<T>::value;
Kirill> +  if (!is_signed)
Kirill> +    return -1;

I don't understand this early return.

If using an unsigned type here is intended to be invalid, then I think
that should be enforced at compile time.

Kirill> -      if (count >= 8 || (count == 7 && firstdigit >= 0x8))
Kirill> +      if (count >= max_count || (count == (max_count - 1)
Kirill> +				 && firstdigit >= 0x8))
Kirill>  	return -1;
 
However, it seems pretty simple to handle unsigned here as well.

thanks,
Tom