Re: [PATCH 2/7] gdb: option completion for 'save gdb-index' command

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> Add proper support for option completion to the 'save gdb-index'
> Andrew> command.  Update save_gdb_index_command function to make use of the
> Andrew> new option_def data structures for parsing the '-dwarf-5' option.
>
> I thought there was some reason this was difficult... the reason the
> 'palves/filename-options' branch exists (maybe only in Pedro's github).

I've only skimmed that branch, but I think that branch is adding options
that are themselves filenames, e.g. '-option FILENAME', but that's not
the case here.  The '-dwarf-5' is the option, and that's separate from
FILENAME.

We already have two other commands that follow the same pattern as I'm
proposing here 'maint print c-tdesc' and 'compile file', admittedly,
neither of these are likely high usage commands, so maybe they are
broken in some subtle way that has never been spotted ...

... anyway, at least for the basic usage I've tested, everything still
seems fine with this change in place.

>
> However if it works then it seems like a good improvement to me.

Thanks,
Andrew