From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/7] gdb: C++-ify mapped_symtab from dwarf2/index-write.c
Date: Mon, 27 Nov 2023 22:21:56 +0000 [thread overview]
Message-ID: <87bkbeq1kr.fsf@redhat.com> (raw)
In-Reply-To: <8734wrf2ai.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> mapped_symtab class can be treated like a contained and iterated
>
> s/contained/container
>
> Andrew> + /* Access the obstack. */
> Andrew> + auto_obstack *obstack ()
>
> A real nit, but it is probably better to just return 'struct obstack *'
> here. Returning an auto_obstack makes it seem like the special auto-
> behavior is important somewhere, but it isn't and/or shouldn't be.
I'll change this and re-test.
Thanks,
Andrew
next prev parent reply other threads:[~2023-11-27 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 17:55 [PATCH 0/7] Changes to gdb-index creation Andrew Burgess
2023-11-27 17:55 ` [PATCH 1/7] gdb: allow use of ~ in 'save gdb-index' command Andrew Burgess
2023-11-27 17:55 ` [PATCH 2/7] gdb: option completion for " Andrew Burgess
2023-11-27 18:58 ` Tom Tromey
2023-11-27 22:20 ` Andrew Burgess
2023-11-27 17:55 ` [PATCH 3/7] gdb/testsuite: small refactor in selftest-support.exp Andrew Burgess
2023-11-27 17:55 ` [PATCH 4/7] gdb: reduce size of generated gdb-index file Andrew Burgess
2023-11-27 17:55 ` [PATCH 5/7] gdb: C++-ify mapped_symtab from dwarf2/index-write.c Andrew Burgess
2023-11-27 19:01 ` Tom Tromey
2023-11-27 22:21 ` Andrew Burgess [this message]
2023-11-27 17:56 ` [PATCH 6/7] gdb: generate gdb-index identically regardless of work thread count Andrew Burgess
2023-11-27 17:56 ` [PATCH 7/7] gdb: generate dwarf-5 index identically as worker-thread count changes Andrew Burgess
2023-11-27 19:38 ` [PATCH 0/7] Changes to gdb-index creation Tom Tromey
2023-11-28 10:34 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkbeq1kr.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).