From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] [gdb/symtab] Fix style issues in v9 .gdb_index section support
Date: Tue, 17 Oct 2023 14:07:29 -0600 [thread overview]
Message-ID: <87edhtqagu.fsf@tromey.com> (raw)
In-Reply-To: <20231011153214.25769-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 11 Oct 2023 17:32:13 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Post-commit review pointed out a few style issues in commit 8b9c08eddac
Tom> ("[gdb/symtab] Add name_of_main and language_of_main to the DWARF index").
Tom> Fix these.
Tom> Tested on x86_64-linux.
Thank you, this looks good.
Approved-By: Tom Tromey <tom@tromey.com>
I found a race in this code as well, I'm working on a fix for that though.
Tom
next prev parent reply other threads:[~2023-10-17 20:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 15:32 Tom de Vries
2023-10-11 15:32 ` [PATCH 2/2] [gdb/symtab] Fix two style issues in gdb/dwarf2/index-write.c Tom de Vries
2023-10-17 20:07 ` Tom Tromey
2023-10-17 20:07 ` Tom Tromey [this message]
2023-10-18 7:17 ` [PATCH 1/2] [gdb/symtab] Fix style issues in v9 .gdb_index section support Tom de Vries
2023-10-19 0:01 ` Tom Tromey
2023-10-19 16:55 ` Thiago Jung Bauermann
2023-10-20 8:21 ` Tom de Vries
2023-10-20 16:50 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edhtqagu.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).