Re: [PATCH] gdb: add HtabPrinter to gdb-gdb.py.in

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> When debugging GDB, I find it a bit tedious to inspect htab_t objects.
Simon> It is possible to find the entries by poking at the fields, but it's
Simon> annoying to do each time.  I think a pretty printer would help.  Add a
Simon> basic one to gdb-gdb.py.

I could have used this today :-}

Simon> +    def _children_generator(self):
Simon> +        size = int(self._val["size"])
Simon> +        entries = self._val["entries"]
Simon> +
Simon> +        child_i = 0
Simon> +        for entries_i in range(size):
Simon> +            entry = entries[entries_i]
Simon> +            # 0 (NULL pointer) means there's nothing, 1 (HTAB_DELETED_ENTRY)
Simon> +            # means there was something, but is now deleted.
Simon> +            if int(entry) in (0, 1):
Simon> +                continue
Simon> +
Simon> +            yield (str(child_i), entry)
Simon> +            child_i += 1
Simon> +
Simon> +    def children(self):
Simon> +        return self._children_generator()

I don't think the indirection here is needed, you can just have children
yield.  But, either way seems fine to me.

Reviewed-By: Tom Tromey <tom@tromey.com>

Tom