From: Tom Tromey <tom@tromey.com>
To: Rustam Kovhaev via Gdb-patches <gdb-patches@sourceware.org>
Cc: Rustam Kovhaev <rkovhaev@gmail.com>
Subject: Re: [RFC PATCH] gdb: add command to clear value history
Date: Thu, 20 Oct 2022 12:44:38 -0600 [thread overview]
Message-ID: <87edv2e3mx.fsf@tromey.com> (raw)
In-Reply-To: <20221019033925.86910-1-rkovhaev@gmail.com> (Rustam Kovhaev via Gdb-patches's message of "Tue, 18 Oct 2022 20:39:28 -0700")
>>>>> "Rustam" == Rustam Kovhaev via Gdb-patches <gdb-patches@sourceware.org> writes:
Rustam> While debugging an application I wanted to clear the value history and I
Rustam> could not find an option to do it.
Rustam> I might be the only one who gets lost in the value history and I am not
Rustam> sure if anyone else needs it, but I thought it would be nice to have it.
Rustam> And I hope this does not break anything.
Rustam> Please let me know what you think. Thanks!
Thanks for the patch.
In addition to what Bruno said, a new feature should have a
documentation patch and also a note in NEWS.
Rustam> +static void
Rustam> +clear_values (const char *ignore, int from_tty)
Rustam> +{
Rustam> + value_history.clear ();
This is indented too much.
Tom
next prev parent reply other threads:[~2022-10-20 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 3:39 Rustam Kovhaev
2022-10-19 8:30 ` Bruno Larsen
2022-10-20 18:44 ` Tom Tromey [this message]
2022-10-23 19:53 ` Rustam Kovhaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edv2e3mx.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=rkovhaev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).