public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Johan Sternerup <johan.sternerup@gmail.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle DAP "stepOut" request in outermost frame
Date: Thu, 25 Apr 2024 12:05:11 -0600	[thread overview]
Message-ID: <87frv9gvxk.fsf@tromey.com> (raw)
In-Reply-To: <87jzklgwig.fsf@tromey.com> (Tom Tromey's message of "Thu, 25 Apr 2024 11:52:39 -0600")

Tom> Maybe one way forward would be a new helper function to be run on the
Tom> gdb thread, that incorporates the new check.

Another way might be to revisit this idea, documented in a comment in
next.py:

# This is a server-side request because it is funny: it wants to
# 'continue' but also return a result, which precludes using
# response=False.  Using 'continue &' would mostly work ok, but this
# yields races when a stop occurs before the response is sent back to
# the client.

That is, solve the stop event race by deferring such events, and then
have all stepping commands add "&" for background execution.  Then they
could all be ordinary requests (on the gdb thread with response), and
any exceptions thrown early by the commands would affect the response.

Tom

  reply	other threads:[~2024-04-25 18:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 17:20 Johan Sternerup
2024-04-25 17:52 ` Tom Tromey
2024-04-25 18:05   ` Tom Tromey [this message]
2024-04-26 18:32     ` Johan Sternerup
2024-04-26 20:28       ` Tom Tromey
2024-04-27  8:24         ` Johan Sternerup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frv9gvxk.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=johan.sternerup@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).