Re: [PATCH] Handle DAP "stepOut" request in outermost frame

[Tom Tromey <tom@tromey.com>]

>>>>> "Johan" == Johan Sternerup <johan.sternerup@gmail.com> writes:

Johan> Previously a "stepOut" request when in the outermost frame would result
Johan> in a sucessful response even though gdb internally would reject the
Johan> associated "finish" request, which means no stoppedEvent would ever be
Johan> sent back to the client. Thus the client would believe the inferior was
Johan> still running and as a consequence reject subsequent "next" and "stepIn"
Johan> requests from the user.

Thanks for the patch.

Johan> The solution here is to make the same check that is made in
Johan> 'infcmd.c/finish_command()' to make sure we're not in the outermost
Johan> frame, but now we do it _before_ actually running the "finish" command
Johan> so that we can send an error response immediately.

Johan> -@request("stepOut", response=False)

... I guess the reason this doesn't "just work" is that response=False
means the exception propagation doesn't really work.

Johan> +@request("stepOut", on_dap_thread=True)
Johan>  def step_out(*, threadId: int, singleThread: bool = False, **args):
Johan> -    _handle_thread_step(threadId, singleThread, True)
Johan> -    exec_and_expect_stop("finish")
Johan> +    if not gdb.selected_frame().older():
Johan> +        raise DAPException("\"finish\" not meaningful in the outermost frame.")

gdb.* APIs can only be used on the gdb thread, so this placement isn't
correct.

Johan> +    send_gdb_with_response(lambda: _handle_thread_step(threadId, singleThread))

Maybe one way forward would be a new helper function to be run on the
gdb thread, that incorporates the new check.

Johan> +if {[dict get $response success] == "true"} {
Johan> +	fail "stepOut from outermost frame should not succeed"
Johan> +} else {
Johan> +    pass "stepOut from outermost frame failed like it should"
Johan> +}
Johan> +
Johan> +dap_check_request_and_response "still stopped and may request backtrace" \
Johan> +	stackTrace {o threadId [i 1]}

Indentation here & before the 'fail' looks wrong.

Tom