From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] More cleanup of defs.h
Date: Tue, 23 Apr 2024 09:00:45 -0600 [thread overview]
Message-ID: <87frvcqg2q.fsf@tromey.com> (raw)
In-Reply-To: <20240423132517.2625632-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Tue, 23 Apr 2024 09:22:55 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Some more cleanup of defs.h. I tested this on the buildbot, but it's
Simon> very possible that it breaks the build on untested platforms. If this
Simon> happens, the fix should be one include away.
This all looks good to me. Thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Simon> gdb/utils.c | 41 -------------------
Shrinking utils.[ch] is always good as well.
Tom
next prev parent reply other threads:[~2024-04-23 15:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 13:22 Simon Marchi
2024-04-23 13:22 ` [PATCH 1/7] gdb: move declarations of check_quit_flag and set_quit_flag to extension.h Simon Marchi
2024-04-25 8:52 ` Alexandra Petlanova Hajkova
2024-04-29 14:46 ` Simon Marchi
2024-04-23 13:22 ` [PATCH 2/7] gdb: change return type of check_quit_flag to bool Simon Marchi
2024-04-27 9:01 ` Alexandra Petlanova Hajkova
2024-04-23 13:22 ` [PATCH 3/7] gdb: change type of quit_flag " Simon Marchi
2024-04-23 13:22 ` [PATCH 4/7] gdb: move a bunch of quit-related things to event-top.{c,h} Simon Marchi
2024-04-23 13:23 ` [PATCH 5/7] gdb: move annotation_level declaration/definition to annotate.{h,c} Simon Marchi
2024-04-23 13:23 ` [PATCH 6/7] gdb: remove enum precision_type Simon Marchi
2024-04-23 13:23 ` [PATCH 7/7] gdb: move symbol_file_command declaration to symfile.h Simon Marchi
2024-04-23 15:00 ` Tom Tromey [this message]
2024-04-23 15:30 ` [PATCH 0/7] More cleanup of defs.h Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frvcqg2q.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).