public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/7] gdb: move declarations of check_quit_flag and set_quit_flag to extension.h
Date: Mon, 29 Apr 2024 10:46:28 -0400	[thread overview]
Message-ID: <462ce004-faf2-416e-a0f1-f22a1dd23de9@polymtl.ca> (raw)
In-Reply-To: <CAJVr-EN7xBaYHt0CpySpFRtiAeN=eg9X7FfhmjJWW8XodnX3OQ@mail.gmail.com>

On 4/25/24 4:52 AM, Alexandra Petlanova Hajkova wrote:
> 
> 
> On Tue, Apr 23, 2024 at 3:25 PM Simon Marchi <simon.marchi@polymtl.ca <mailto:simon.marchi@polymtl.ca>> wrote:
> 
>     Move them out of defs.h, to extension.h, since the implementations are
>     in extension.c.
> 
>     Change-Id: Ie7321468bd7fecc684d70b09f72c3ee8ac75d8f4
> 
> 
> This looks like a reasonable change and also it introduce no regressions on Fedora Rawhide aarch64.

Hi Alexandra,

Thanks for the review.  If you would like to get an acknowledgement for
your time spent reviewing or testing, you can reply with a tag such as:

Reviewed-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>

or

Tested-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>

You can also put both if you reviewed the code and did some testing.

The committer will then put these as git trailers in the commit message.

See: https://sourceware.org/gdb/wiki/ContributionChecklist#Receiving_positive_reviews

Simon

  reply	other threads:[~2024-04-29 14:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 13:22 [PATCH 0/7] More cleanup of defs.h Simon Marchi
2024-04-23 13:22 ` [PATCH 1/7] gdb: move declarations of check_quit_flag and set_quit_flag to extension.h Simon Marchi
2024-04-25  8:52   ` Alexandra Petlanova Hajkova
2024-04-29 14:46     ` Simon Marchi [this message]
2024-04-23 13:22 ` [PATCH 2/7] gdb: change return type of check_quit_flag to bool Simon Marchi
2024-04-27  9:01   ` Alexandra Petlanova Hajkova
2024-04-23 13:22 ` [PATCH 3/7] gdb: change type of quit_flag " Simon Marchi
2024-04-23 13:22 ` [PATCH 4/7] gdb: move a bunch of quit-related things to event-top.{c,h} Simon Marchi
2024-04-23 13:23 ` [PATCH 5/7] gdb: move annotation_level declaration/definition to annotate.{h,c} Simon Marchi
2024-04-23 13:23 ` [PATCH 6/7] gdb: remove enum precision_type Simon Marchi
2024-04-23 13:23 ` [PATCH 7/7] gdb: move symbol_file_command declaration to symfile.h Simon Marchi
2024-04-23 15:00 ` [PATCH 0/7] More cleanup of defs.h Tom Tromey
2024-04-23 15:30   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462ce004-faf2-416e-a0f1-f22a1dd23de9@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=ahajkova@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).