Re: [PATCH 0/5] Various test suite fixes (mostly thread related)

[Tom Tromey <tom@tromey.com>]

John> I've been working on a series of patches for the FreeBSD native target
John> to fix various issues with multiprocessing over the past month or two.
John> During that time I have fixed a few issues in various tests I've
John> observed so far.  This series is just some of the test fixes.

Thank you for doing this.

John> Patches 3 and 4 fix synchronization issues where tests were assuming
John> that if the main thread calls pthread_create and then exits, the new
John> thread will start executing bofore the main thread exits.

I like the barrier technique.

John> The last patch is a bit more of a RFC and probably not really the way
John> we want to fix the issue.  Some tests assume that the format of 'info
John> threads' is to have thread identifiers start with "Thread".  However,
John> some targets use a different format.  For example FreeBSD's native
John> target refers to threads as "LWP <nnnn>".  There are some existing
John> tests that use a looser regex here already rather than requiring the
John> word "Thread".  I wonder if we want to define a helper macro or
John> variable or like to contain the regex to use for matching on a valid
John> thread identifier instead?

I think a helper variable would be fine.  We already have a few of these
in gdb.exp, like 'octal' or 'bkptno_numopt_re'.

I think patches 1-4 are OK as-is.

thanks,
Tom