From: Tom Tromey <tom@tromey.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Convert say_where to method on code_breakpoint
Date: Tue, 10 Jan 2023 16:35:01 -0700 [thread overview]
Message-ID: <87fsci55ga.fsf@tromey.com> (raw)
In-Reply-To: <20230110151821.2302229-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Tue, 10 Jan 2023 08:18:21 -0700")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> 'say_where' is only useful (and only called for) code breakpoints, so
Tom> convert it to be a protected method on code_breakpoint.
Tom> - struct bp_location *loc = b->loc;
Tom> + struct bp_location *loc = loc;
Tom> int n = 0;
Tom> for (; loc; loc = loc->next)
Tom> ++n;
This hunk is wrong but I didn't notice until now.
Sorry about this. I'll fix it momentarily.
Tom
prev parent reply other threads:[~2023-01-10 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 15:18 Tom Tromey
2023-01-10 16:24 ` Simon Marchi
2023-01-10 23:35 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsci55ga.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).