[PATCH] Remove unused parameter in maybe_software_singlestep

[PATCH] Remove unused parameter in maybe_software_singlestep

[Lancelot SIX]

While working around, I noticed that the last parameter of
maybe_software_singlestep is never used.  This path removes
it.

Built on x86_64-linux-gnu and riscv64-linux-gnu.

gdb/ChangeLog:

	* infrun.c (maybe_software_singlestep): Remove unused PC
	parameter.
	(resume_1): Update calls to maybe_software_singlestep.
---
 gdb/infrun.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/gdb/infrun.c b/gdb/infrun.c
index 9469b74af39..eda713d9fb3 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -89,7 +89,7 @@ static void insert_step_resume_breakpoint_at_caller (struct frame_info *);
 
 static void insert_longjmp_resume_breakpoint (struct gdbarch *, CORE_ADDR);
 
-static bool maybe_software_singlestep (struct gdbarch *gdbarch, CORE_ADDR pc);
+static bool maybe_software_singlestep (struct gdbarch *gdbarch);
 
 static void resume (gdb_signal sig);
 
@@ -2051,11 +2051,10 @@ bool sched_multi = false;
 /* Try to setup for software single stepping over the specified location.
    Return true if target_resume() should use hardware single step.
 
-   GDBARCH the current gdbarch.
-   PC the location to step over.  */
+   GDBARCH the current gdbarch.  */
 
 static bool
-maybe_software_singlestep (struct gdbarch *gdbarch, CORE_ADDR pc)
+maybe_software_singlestep (struct gdbarch *gdbarch)
 {
   bool hw_step = true;
 
@@ -2390,7 +2389,7 @@ resume_1 (enum gdb_signal sig)
 	  set_step_over_info (regcache->aspace (),
 			      regcache_read_pc (regcache), 0, tp->global_num);
 
-	  step = maybe_software_singlestep (gdbarch, pc);
+	  step = maybe_software_singlestep (gdbarch);
 
 	  insert_breakpoints ();
 	}
@@ -2409,7 +2408,7 @@ resume_1 (enum gdb_signal sig)
 
   /* Do we need to do it the hard way, w/temp breakpoints?  */
   else if (step)
-    step = maybe_software_singlestep (gdbarch, pc);
+    step = maybe_software_singlestep (gdbarch);
 
   /* Currently, our software single-step implementation leads to different
      results than hardware single-stepping in one situation: when stepping
-- 
2.31.1

Re: [PATCH] Remove unused parameter in maybe_software_singlestep

[Tom Tromey]

>>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:

Lancelot> While working around, I noticed that the last parameter of
Lancelot> maybe_software_singlestep is never used.  This path removes

Typo in the text here, "path" -> "patch".

Lancelot> gdb/ChangeLog:

Lancelot> 	* infrun.c (maybe_software_singlestep): Remove unused PC
Lancelot> 	parameter.
Lancelot> 	(resume_1): Update calls to maybe_software_singlestep.

Looks good.  Thank you.

Tom

Re: [PATCH] Remove unused parameter in maybe_software_singlestep

[Lancelot SIX]

Hi,

I have pushed this to master, with a minor modification to the comment
for maybe_software_singlestep.  It stilles contained reference to the
removed parameter, I changed it from

	/* Try to setup for software single stepping over the specified location.
	   Return true if target_resume() should use hardware single step.

to

	/* Try to setup for software single stepping.  Return true if target_resume()
	   should use hardware single step.

Lancelot.


On Thu, Jul 01, 2021 at 07:12:05AM -0600, Tom Tromey wrote:
> >>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Lancelot> While working around, I noticed that the last parameter of
> Lancelot> maybe_software_singlestep is never used.  This path removes
> 
> Typo in the text here, "path" -> "patch".
> 
> Lancelot> gdb/ChangeLog:
> 
> Lancelot> 	* infrun.c (maybe_software_singlestep): Remove unused PC
> Lancelot> 	parameter.
> Lancelot> 	(resume_1): Update calls to maybe_software_singlestep.
> 
> Looks good.  Thank you.
> 
> Tom