Re: [PATCH 2/2] Nios2, gdb: Adjust to new coredump format

[Tom Tromey <tom@tromey.com>]

>>>>> "Moritz" == Moritz Strübe <moritz.struebe@siemens-energy.com> writes:

Thank you for the patch.

Moritz> Current kernels create their coredumps using ptrace. Adjust to this new
Moritz> format.

Is there any need to support old coredumps as well; and if not, why not?

Moritz> +/* Registers not set by dump */
Moritz> +static std::set<int> notsetregs = {0, 24, 25, 30};

Should be const.

Moritz>  /* Implement the supply_regset hook for core files.  */
Moritz> -
Moritz>  static void

Spurious change.

Moritz> +  // If regno is 0 dump all registers
Moritz> +  if(regnum > 0 ){
Moritz> +    regcache->raw_supply (regnum, gregs + 4 * regnum);
Moritz> +  } else {

gdb doesn't use '//' comments and also uses a different formatting
style.

thanks,
Tom