Re: [PATCH] Throw error when creating an overly large gdb-index file

[Tom Tromey <tom@tromey.com>]

>>>>> "Kevin" == Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org> writes:

Kevin> The shared object is 3 GiB in size and the gdb-index section for it is
Kevin> 4.3 GiB in size.

Thanks.

Kevin> I extracted .debug_str using obj_copy, replaced the \0 characters
Kevin> with newlines, and then used sort and uniq on that output.  There
Kevin> were no duplicate lines.  Altogether, there are 1,212,620 strings
Kevin> in .debug_str.

Kevin> I can't say that I fully understand the layout of the constant pool,
Kevin> but it appears that all of the strings from .debug_str will end in the
Kevin> latter part of it.  So, if I'm right, that alone accounts for nearly
Kevin> half the size of the index file.

Yeah, putting copies into the constant pool was a mistake; though I
think part of my rationale was that often the constant pool will hold
different versions -- they go through name canonicalization.

Anyway your patch looks good to me.  Thank you.

Tom