From: Tom Tromey <tom@tromey.com>
To: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
Cc: Kevin Buettner <kevinb@redhat.com>
Subject: Re: [PATCH] Throw error when creating an overly large gdb-index file
Date: Tue, 12 Sep 2023 10:07:49 -0600 [thread overview]
Message-ID: <87o7i7jrxm.fsf@tromey.com> (raw)
In-Reply-To: <20230909025521.3128935-2-kevinb@redhat.com> (Kevin Buettner via Gdb-patches's message of "Fri, 8 Sep 2023 19:55:22 -0700")
>>>>> "Kevin" == Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org> writes:
Kevin> The header in a .gdb_index section uses 32-bit unsigned offsets to
Kevin> refer to other areas of the section. Thus, there is a size limit of
Kevin> 2^32-1 which is currently unaccounted for by GDB's code for outputting
Kevin> these sections.
...
Kevin> This commit prevents the internal error from occurring by calling error()
Kevin> when the file size exceeds 2^32-1.
I don't have a problem with this but... why is the section too long?
I wonder if this is covering up some other bug, like maybe not enough
symbol de-duplication.
Tom
next prev parent reply other threads:[~2023-09-12 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 2:55 Kevin Buettner
2023-09-09 5:19 ` Kevin Buettner
2023-09-09 8:20 ` Tom de Vries
2023-09-15 0:22 ` Kevin Buettner
2023-09-15 9:09 ` Tom de Vries
2023-09-12 16:07 ` Tom Tromey [this message]
2023-09-13 2:43 ` Kevin Buettner
2023-09-13 14:24 ` Tom Tromey
2023-09-15 0:10 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7i7jrxm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).