From: Tom Tromey <tromey@adacore.com>
To: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use frame.name() in FrameDecorator
Date: Thu, 03 Aug 2023 09:36:04 -0600 [thread overview]
Message-ID: <87h6pgb0kb.fsf@tromey.com> (raw)
In-Reply-To: <CAJVr-EPW+EL8f00QwQfOuWrLgZsPrzKdMkt=BfNaaEGH0aDZ_A@mail.gmail.com> (Alexandra Petlanova Hajkova's message of "Thu, 3 Aug 2023 15:50:17 +0200")
>>>>> Alexandra Petlanova Hajkova <ahajkova@redhat.com> writes:
>> However, there's a different approach we can take: the code here can
>> simply use Frame.name. This handles the PC problem correctly, and
>> gets us the information we need.
> I tested this for Fedora-Rawhide on ppc64le. I can confirm this causes
> no regressions and I can see {"id": 1, "name": "no_debug_info", is
> outputted instead of {"id": 1, "name": 268501652.
Thank you. I'm going to check this in.
Tom
prev parent reply other threads:[~2023-08-03 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 20:06 Tom Tromey
2023-08-03 13:50 ` Alexandra Petlanova Hajkova
2023-08-03 15:36 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6pgb0kb.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).