From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Fix result of DAP setExpression
Date: Fri, 07 Jul 2023 13:57:04 -0600 [thread overview]
Message-ID: <87h6qfsdf3.fsf@tromey.com> (raw)
In-Reply-To: <20230628135610.2695419-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 28 Jun 2023 07:56:10 -0600")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> A co-worker, Andry, noticed that the DAP setExpression implementation
Tom> returned the wrong fields -- it used "result" rather than "value", and
Tom> included "memoryReference", which isn't in the spec (an odd oversight,
Tom> IMO).
Tom> This patch fixes the problems.
I'm checking this in.
Tom
prev parent reply other threads:[~2023-07-07 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 13:56 Tom Tromey
2023-07-07 19:57 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6qfsdf3.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).