Re: [PATCHv2 0/3] Fix for 'make tags' build rule

[Andrew Burgess <aburgess@redhat.com>]

Andrew Burgess <aburgess@redhat.com> writes:

> Hi Reuben,
>
> Thanks for working on this, sorry your original patch didn't get
> merged.
>
> I took a look at your updated patch, and noticed what I think is a
> merge issue with your update, you've removed gdb_select.h, but added
> back in gdb_regex.h, I don't think this is intentional.
>
> Anyway, I was going to fix that and push your patch, but first I
> thought I'd test 'make tags' - and I noticed some additional problems.
>
> The series below fixes these issues.
>
>  #1 - this is a general clean up, and is not really related to 'make
>       tags' at all,
>
>  #2 - this is your patch, but with the merge issue mentioned above
>       fixed.
>
>  #3 - this fixes some additional warnings I was seeing from 'make
>       tags'.
>
> I'll give this some time for folk to comment before pushing.

I've gone ahead and pushed this series.  I think all the fixes are
reasonably obvious.

Thanks,
Andrew



>
> Thanks for your work on this,
>
> Andrew
>
> ---
>
> Andrew Burgess (2):
>   gdb/Makefile.in: remove SOURCES variable
>   gdb/Makefile.in: move ALLDEPFILES earlier in Makefile.in
>
> Reuben Thomas (1):
>   gdb/Makefile.in: fix 'make tags' build target
>
>  gdb/Makefile.in | 449 ++++++++++++++++++++++++------------------------
>  1 file changed, 229 insertions(+), 220 deletions(-)
>
> -- 
> 2.25.4