From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb: small cleanup in symbol_file_add_with_addrs
Date: Thu, 14 Sep 2023 10:17:16 -0600 [thread overview]
Message-ID: <87il8chgqb.fsf@tromey.com> (raw)
In-Reply-To: <6219a1ae148c0b9796f7153b9a6c3b7173fb8f5a.1694706545.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 14 Sep 2023 16:49:29 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> I'm not sure how this change could be tested, I don't believe there's
Andrew> any GDB (maintenance) command that displays the BFD cache contents, so
Andrew> we can't check the cache contents easily. Ideas are welcome though.
Also, the cache isn't really inspectable without reaching into BFD
internals.
This patch looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-09-14 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 15:49 Andrew Burgess
2023-09-14 16:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il8chgqb.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).