From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Fix thread exited messages for remote targets
Date: Wed, 23 Aug 2023 10:12:57 +0100 [thread overview]
Message-ID: <87il96azqe.fsf@redhat.com> (raw)
In-Reply-To: <611e248d-9555-2519-dac6-7adf0e019230@palves.net>
Pedro Alves <pedro@palves.net> writes:
> On 2023-08-21 10:31, Andrew Burgess wrote:
>> The point of this series is to fix the thread ... exited messages for
>> remote targets. I made a previous attempt to fix this issue:
>>
>> https://inbox.sourceware.org/gdb-patches/0215c520c680334efac7f0544d834ec1fb7aff8e.1669634536.git.aburgess@redhat.com/
>> https://inbox.sourceware.org/gdb-patches/d6d49338119d2a32e060f95219aacac31bdf4886.1674207665.git.aburgess@redhat.com/
>>
>> But Pedro hinted that he had a better solution as part of his step
>> over clone/exit work, the latest version of which can be found here:
>>
>> https://inbox.sourceware.org/gdb-patches/20221212203101.1034916-31-pedro@palves.net/
>>
>> Unfortunately, the larger series, of which that commit is a part,
>> seems to have stalled.
>
> Yeah, sorry, I saw your reviews a few weeks ago, so I started reviewing your infcalls series as
> a way to "pay" for your reviews, before addressing your comments in my series, but
> then summer vacations and other priorities got in the way. I still have every interest to get that
> series merged.
>
>> However, that particular patch doesn't really
>> depend on anything else in the series, and so, in this series I've
>> pulled out this one patch (3/3), along with one other patch on which
>> the above sort-of depended (1/3 - this changes a similar area of GDB).
>
> Thank you.
>
>>
>> The remaining patch (2/3) is my own work, and is an additional
>> refactor which I think follows naturally from the first patch.
>>
>> Patches #1 and #3 are mostly Pedro's work, though, some updates were
>> needed during the rebase. Any bugs introduced by the rebase are mine.
>>
>
> All looks good to me, please go ahead and merge it.
Pushed.
Thanks,
Andrew
prev parent reply other threads:[~2023-08-23 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 9:31 Andrew Burgess
2023-08-21 9:31 ` [PATCH 1/3] gdb: make inferior::clear_thread_list always silent Andrew Burgess
2023-08-21 9:31 ` [PATCH 2/3] gdb: remove the silent parameter from exit_inferior_1 and cleanup Andrew Burgess
2023-08-21 9:31 ` [PATCH 3/3] gdb: centralize "[Thread ...exited]" notifications Andrew Burgess
2023-08-21 16:10 ` [PATCH 0/3] Fix thread exited messages for remote targets John Baldwin
2023-08-22 13:07 ` Pedro Alves
2023-08-22 16:54 ` John Baldwin
2023-08-22 13:02 ` Pedro Alves
2023-08-23 9:12 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il96azqe.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).