Re: [PATCH 0/3] Fix thread exited messages for remote targets

[Pedro Alves <pedro@palves.net>]

On 2023-08-21 10:31, Andrew Burgess wrote:
> The point of this series is to fix the thread ... exited messages for
> remote targets.  I made a previous attempt to fix this issue:
> 
>   https://inbox.sourceware.org/gdb-patches/0215c520c680334efac7f0544d834ec1fb7aff8e.1669634536.git.aburgess@redhat.com/
>   https://inbox.sourceware.org/gdb-patches/d6d49338119d2a32e060f95219aacac31bdf4886.1674207665.git.aburgess@redhat.com/
> 
> But Pedro hinted that he had a better solution as part of his step
> over clone/exit work, the latest version of which can be found here:
> 
>   https://inbox.sourceware.org/gdb-patches/20221212203101.1034916-31-pedro@palves.net/
> 
> Unfortunately, the larger series, of which that commit is a part,
> seems to have stalled.  

Yeah, sorry, I saw your reviews a few weeks ago, so I started reviewing your infcalls series as
a way to "pay" for your reviews, before addressing your comments in my series, but
then summer vacations and other priorities got in the way.  I still have every interest to get that
series merged.

> However, that particular patch doesn't really
> depend on anything else in the series, and so, in this series I've
> pulled out this one patch (3/3), along with one other patch on which
> the above sort-of depended (1/3 - this changes a similar area of GDB).

Thank you.

> 
> The remaining patch (2/3) is my own work, and is an additional
> refactor which I think follows naturally from the first patch.
> 
> Patches #1 and #3 are mostly Pedro's work, though, some updates were
> needed during the rebase.  Any bugs introduced by the rebase are mine.
> 

All looks good to me, please go ahead and merge it.

Pedro Alves

> ---
> 
> Andrew Burgess (1):
>   gdb: remove the silent parameter from exit_inferior_1 and cleanup
> 
> Pedro Alves (2):
>   gdb: make inferior::clear_thread_list always silent
>   gdb: centralize "[Thread ...exited]" notifications
> 
>  gdb/annotate.c                                |  4 +-
>  gdb/breakpoint.c                              |  4 +-
>  gdb/bsd-kvm.c                                 |  2 +-
>  gdb/corelow.c                                 |  2 +-
>  gdb/fbsd-nat.c                                |  3 -
>  gdb/gdbthread.h                               | 22 ++++++--
>  gdb/inferior.c                                | 35 ++++--------
>  gdb/inferior.h                                | 12 ++--
>  gdb/infrun.c                                  |  2 +-
>  gdb/interps.c                                 |  6 +-
>  gdb/interps.h                                 |  8 ++-
>  gdb/linux-nat.c                               |  8 +--
>  gdb/mi/mi-interp.c                            |  4 +-
>  gdb/mi/mi-interp.h                            |  3 +-
>  gdb/netbsd-nat.c                              |  3 -
>  gdb/observable.h                              | 11 ++--
>  gdb/procfs.c                                  |  6 --
>  gdb/python/py-inferior.c                      |  4 +-
>  gdb/testsuite/gdb.mi/mi-thread-bp-deleted.exp | 14 +----
>  .../gdb.threads/thread-bp-deleted.exp         | 12 +---
>  gdb/thread.c                                  | 56 +++++++++++++------
>  gdb/tracectf.c                                |  2 +-
>  gdb/tracefile-tfile.c                         |  2 +-
>  gdb/windows-nat.c                             | 20 ++-----
>  24 files changed, 121 insertions(+), 124 deletions(-)
> 
> 
> base-commit: b080fe54fb3414b488b8ef323c6c50def061f918