From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] [gdb/symtab] Fix off-by-one error in cooked_indexer::recurse
Date: Thu, 10 Aug 2023 10:28:46 -0600 [thread overview]
Message-ID: <87il9m3lq9.fsf@tromey.com> (raw)
In-Reply-To: <20230809150857.22557-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 9 Aug 2023 17:08:57 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> Test-case gdb.dwarf2/pr13961.exp contains:
Tom> ...
Tom> <1><25>: Abbrev Number: 8 (DW_TAG_class_type)
Tom> <26> DW_AT_specification: <0x2a>
Tom> <1><2a>: Abbrev Number: 2 (DW_TAG_class_type)
Tom> <2b> DW_AT_name : foo
Tom> <2f> DW_AT_byte_size : 4
Tom> <30> DW_AT_decl_file : 1
Tom> <31> DW_AT_decl_line : 1
Tom> <32> DW_AT_sibling : <0x44>
It took me a while to understand the problem here, but I get it now.
Thanks for doing this.
Approved-By: Tom Tromey <tom@tromey.com>
BTW this is maybe my least favorite part of DWARF, though the
competition is pretty tough.
Tom
prev parent reply other threads:[~2023-08-10 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 15:08 Tom de Vries
2023-08-10 16:11 ` Tom de Vries
2023-08-10 16:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il9m3lq9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).