From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Andrew Burgess <aburgess@redhat.com>,
gdb-patches@sourceware.org, Matt Turner <mattst88@gmail.com>
Subject: Re: [PATCH] Linux: Avoid pread64/pwrite64 for high memory addresses (PR gdb/30525)
Date: Thu, 06 Jul 2023 09:25:59 -0600 [thread overview]
Message-ID: <87ilaxukmw.fsf@tromey.com> (raw)
In-Reply-To: <ba2291d5-274d-0c1a-2afd-4b00c6a6bef3@palves.net> (Pedro Alves's message of "Thu, 6 Jul 2023 14:54:06 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> I just realized that the lseek path, which I just reindented, has an if branch
Pedro> with more than one line which isn't using braces... The patch should at least be
Pedro> consistent in all the lines it touches... :-) If we follow the documented convention,
Pedro> then here's what we get.
Pedro> WDYT? Should we tweak the convention instead?
I tend to interpret this rule as "two statements and/or comments", so
braces are required if there's a comment but not for a single statement
that happens to be broken up across multiple lines.
Tom
next prev parent reply other threads:[~2023-07-06 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 13:41 Pedro Alves
2023-07-05 14:45 ` Matt Turner
2023-07-05 17:59 ` Andrew Burgess
2023-07-06 13:43 ` Pedro Alves
2023-07-06 13:54 ` Pedro Alves
2023-07-06 15:25 ` Tom Tromey [this message]
2023-07-06 16:47 ` Pedro Alves
2023-07-06 17:00 ` Pedro Alves
2023-07-07 15:18 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilaxukmw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mattst88@gmail.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).