public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 2/3] [gdb/tui] Fix left margin in disassembly window
Date: Thu, 13 Apr 2023 10:12:27 +0100	[thread overview]
Message-ID: <87ile09mdg.fsf@redhat.com> (raw)
In-Reply-To: <8de9c7c9-5d88-0923-403d-c291a8d64340@suse.de>

Tom de Vries <tdevries@suse.de> writes:

> On 4/12/23 23:06, Andrew Burgess wrote:
>> I'm surprised there's no new test for this.  I kind of assumed the new
>> maint command (from patch #1) was to make writing the test easier...
>> 
>
> It certainly could be used for that, yes.  My primary purpose though was 
> to make the problem easily visible.
>
> I haven't added a test because I'm still fixing issues I find with the 
> current testsuite...
>
> I might add a test-case for this eventually, or hijack one of the 
> existing tests.

I don't understand -- aren't you proposing this patch for inclusion now?

Patches should be accompanied by a corresponding test.

I really think this should have a test before it's merged.

Thanks,
Andrew


  reply	other threads:[~2023-04-13  9:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11  8:23 [PATCH 1/3] [gdb/tui] Add maint set/show tui-left-margin-verbose Tom de Vries
2023-04-11  8:23 ` [PATCH 2/3] [gdb/tui] Fix left margin in disassembly window Tom de Vries
2023-04-12 20:43   ` Tom Tromey
2023-04-12 21:06   ` Andrew Burgess
2023-04-12 22:25     ` Tom de Vries
2023-04-13  9:12       ` Andrew Burgess [this message]
2023-04-13  9:25         ` Andrew Burgess
2023-04-13 15:05           ` Tom de Vries
2023-04-11  8:23 ` [PATCH 3/3] [gdb/tui] Revert workaround in tui_source_window::show_line_number Tom de Vries
2023-04-12 20:44   ` Tom Tromey
2023-04-11  8:47 ` [PATCH 1/3] [gdb/tui] Add maint set/show tui-left-margin-verbose Eli Zaretskii
2023-04-12 22:21   ` Tom de Vries
2023-04-12 20:42 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ile09mdg.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).