Re: [PATCH 1/3] [gdb/tui] Add maint set/show tui-left-margin-verbose

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Tom Tromey <tom@tromey.com>
> Date: Tue, 11 Apr 2023 10:23:30 +0200
> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
> 
>  gdb/doc/gdb.texinfo     |  8 ++++++++
>  gdb/tui/tui-source.c    |  5 ++++-
>  gdb/tui/tui-win.c       | 16 ++++++++++++++++
>  gdb/tui/tui-win.h       |  3 +++
>  gdb/tui/tui-winsource.c |  7 ++++++-
>  5 files changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 2d5358a792b..bb96ddb2d52 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -41242,6 +41242,14 @@ has been resized.  This setting is intended for use by the test suite,
>  where it would otherwise be difficult to determine when a resize and
>  refresh has been completed.
>  
> +@kindex maint set tui-left-margin-verbose
> +@kindex maint show tui-left-margin-verbose
> +@item maint set tui-left-margin-verbose
> +@item maint show tui-left-margin-verbose
> +Control whether the left margin of the TUI source and disassembly windows
> +uses @samp{_} and @samp{0} at locations where otherwise there would be a
> +space.  The default is @code{off}, which means spaces are used.

This is okay, but I suggest adding a sentence explaining the rationale
for using this command.  Otherwise, its purpose is unclear, not
without reading the description you included in the commit log.

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>