Re: [PATCH 0/4] Python API: Accept named arguments in a few more places

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> As this function takes two arguments I though that accepting named
> Andrew> arguments might be a nice improvement.
>
> We actually document this.
>
>        Functions and methods which have two or more optional arguments allow
>     them to be specified using keyword syntax.  This allows passing some
>     optional arguments while skipping others.  Example:
>     'gdb.some_function ('foo', bar = 1, baz = 2)'.
>
> Andrew> Then for completeness I updated the other two methods in py-unwind.c
> Andrew> that also didn't accept named arguments, even though these functions
> Andrew> only take a single argument I think taking named arguments is in
> Andrew> general better, and consistency is good too.
>
> It seems reasonable to me; certainly doesn't hurt anything.
>
> This all looks fine to me.  Thanks for doing it.
>
> Reviewed-By: Tom Tromey <tom@tromey.com>

Pushed.

Thanks,
Andrew