From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] gdb/python: have UnwindInfo.add_saved_register accept named args
Date: Thu, 30 Mar 2023 17:08:50 +0300 [thread overview]
Message-ID: <83v8ii49hp.fsf@gnu.org> (raw)
In-Reply-To: <0d08cca8737eff64400b5bb973bed259e4affa7e.1680177890.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Thu, 30 Mar 2023 13:10:20 +0100)
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Thu, 30 Mar 2023 13:10:20 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
>
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -2882,8 +2882,8 @@
> create a @code{gdb.UnwindInfo} instance. Use the following method to
> specify caller registers that have been saved in this frame:
>
> -@defun gdb.UnwindInfo.add_saved_register (reg, value)
> -@var{reg} identifies the register, for a description of the acceptable
> +@defun gdb.UnwindInfo.add_saved_register (@var{register}, @var{value})
> +@var{register} identifies the register, for a description of the acceptable
> values see @ref{gdbpy_frame_read_register,,Frame.read_register}.
> @var{value} is a register value (a @code{gdb.Value} object).
> @end defun
Why did you use @var inside the argument list on a @defun line? That
shouldn't be necessary, and the original text didn't use that.
Otherwise, this is okay (although the change just modifies the name of
a single argument, so I'm not sure why we are doing this). Thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-03-30 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 12:10 [PATCH 0/4] Python API: Accept named arguments in a few more places Andrew Burgess
2023-03-30 12:10 ` [PATCH 1/4] gdb/python: have UnwindInfo.add_saved_register accept named args Andrew Burgess
2023-03-30 14:08 ` Eli Zaretskii [this message]
2023-04-06 14:10 ` Andrew Burgess
2023-03-30 12:10 ` [PATCH 2/4] gdb/python: have PendingFrame methods accept keyword arguments Andrew Burgess
2023-03-30 14:13 ` Eli Zaretskii
2023-03-30 12:10 ` [PATCH 3/4] gdb/python: convert Frame.read_register to take named arguments Andrew Burgess
2023-03-30 14:10 ` Eli Zaretskii
2023-03-30 12:10 ` [PATCH 4/4] gdb/python: allow Frame.read_var to accept " Andrew Burgess
2023-03-30 14:11 ` Eli Zaretskii
2023-04-04 18:39 ` [PATCH 0/4] Python API: Accept named arguments in a few more places Tom Tromey
2023-04-06 14:11 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8ii49hp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).