From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash with "finish" in Rust
Date: Mon, 27 Feb 2023 11:05:37 -0700 [thread overview]
Message-ID: <87ilfndlvy.fsf@tromey.com> (raw)
In-Reply-To: <20230209192755.498183-1-tom@tromey.com> (Tom Tromey's message of "Thu, 9 Feb 2023 12:27:55 -0700")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> PR rust/30090 points out that a certain "finish" in a Rust program
Tom> will cause gdb to crash. This happens due to some confusion about
Tom> field indices in rust_language::print_enum. The fix is to use
Tom> value_primitive_field so that the correct type can be passed; other
Tom> spots in rust-lang.c already do this.
Tom> Note that the enclosed test case comes with an xfail. This is needed
Tom> because for this function, rustc doesn't follow the platform ABI.
Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30090
I'm going to check this in now.
Tom
prev parent reply other threads:[~2023-02-27 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 19:27 Tom Tromey
2023-02-27 18:05 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilfndlvy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).