public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] Un-break the coff-pe-read.c build
@ 2022-04-22 15:29 Tom Tromey
  2022-04-22 16:12 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2022-04-22 15:29 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

This fixes a build breakage in my recent coff-pe-read.c change.

I'm sorry about this.  I don't understand how it happened, because I
definitely built and tested the series on Windows, and I didn't change
it before pushing.  Something must have gone wrong on the Windows
build, but I don't know what.  I'll investigate and and re-test to be
sure.
---
 gdb/coff-pe-read.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
index d533a96ef6d..72bd43b23d8 100644
--- a/gdb/coff-pe-read.c
+++ b/gdb/coff-pe-read.c
@@ -208,7 +208,7 @@ add_pe_forwarded_sym (minimal_symbol_reader &reader,
   if (debug_coff_pe_read > 1)
     gdb_printf (gdb_stdlog, _("Adding forwarded exported symbol"
 			      " \"%s\" in dll \"%s\", pointing to \"%s\"\n"),
-		sym_name, dll_name, forward_qualified_name);
+		sym_name, dll_name, forward_qualified_name.c_str ());
 
   vma = msymbol.value_address ();
   msymtype = msymbol.minsym->type ();
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pushed] Un-break the coff-pe-read.c build
  2022-04-22 15:29 [pushed] Un-break the coff-pe-read.c build Tom Tromey
@ 2022-04-22 16:12 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2022-04-22 16:12 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

Tom> I'm sorry about this.  I don't understand how it happened, because I
Tom> definitely built and tested the series on Windows, and I didn't change
Tom> it before pushing.  Something must have gone wrong on the Windows
Tom> build, but I don't know what.  I'll investigate and and re-test to be
Tom> sure.

It took me a little while to figure out, but I think the problem is that
this build doesn't enable the printf format-checking warnings.  So, it
did build and test -- but didn't get the error (and didn't crash because
this is a logging printf).

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-22 16:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 15:29 [pushed] Un-break the coff-pe-read.c build Tom Tromey
2022-04-22 16:12 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).