Re: [PATCH] gdb:csky add support target-descriptions for CSKY arch

[Tom Tromey <tom@tromey.com>]

>>>>> Jiangshuai Li <jiangshuai_li@c-sky.com> writes:

Thank you for the patch.

I don't know anything about csky and so I can't really review any of the
architecture details.  I'll just take your word for that.

> diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c
> index 04f558cf14b..447baa1ed58 100644
> --- a/gdb/csky-tdep.c
> +++ b/gdb/csky-tdep.c
> @@ -67,6 +67,424 @@ static struct reggroup *vr_reggroup;
>  static struct reggroup *mmu_reggroup;
>  static struct reggroup *prof_reggroup;
 
> +static char *csky_supported_tdesc_feature_names[] = {
> +  (char *)"org.gnu.csky.abiv2.gpr",

I think the casts here are a red flag, you ought to make the array use
"const char *".

> +struct csky_supported_tdesc_register
> +{
> +  char name[16];

I think "const char *" here is probably better as well, just because
it's more idiomatic.

> +/* Get csky supported registers's count for tdesc xml.  */
> +static int
> +csky_get_supported_tdesc_registers_count()
> +{
> +  int count = 0;
> +  int size = sizeof (struct csky_supported_tdesc_register);
> +  count += sizeof (csky_supported_gpr_regs)/size;
> +  count += sizeof (csky_supported_fpu_regs)/size;

I suggest using the ARRAY_SIZE macro instead.

> +/* Return a supported register according to index.  */
> +static struct csky_supported_tdesc_register *
> +csky_get_supported_register_by_index (int index)
> +{
> +  static struct csky_supported_tdesc_register tdesc_reg;
> +  int count = 0;
> +  int multi, remain;
> +  int size = sizeof (struct csky_supported_tdesc_register);
> +  int count_gpr = sizeof (csky_supported_gpr_regs)/size;

Here too.

> +/* Check whether xml has discribled the essential regs.  */

Typo, "described".

Tom