From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add Rust parser check for end of expression
Date: Fri, 18 Mar 2022 10:58:44 -0600 [thread overview]
Message-ID: <87ilsbfb97.fsf@tromey.com> (raw)
In-Reply-To: <1cd1981e-658e-dd2f-1ab7-e696dd7ef2ff@palves.net> (Pedro Alves's message of "Fri, 18 Mar 2022 16:00:31 +0000")
>> I noticed that "print 5," passed in Rust -- the parser wasn't checking
>> that the entire input was used. This patch fixes the problem. This
>> in turn pointed out another bug in the parser, namely that it didn't
>> lex the next token after handling a string token. This is also fixed
>> here.
Pedro> OOC, is the lex-next-token bug something that is also covered by
Pedro> the added test? It doesn't seem to use strings.
Yes, if you remove that hunk there will be other regressions.
Tom
next prev parent reply other threads:[~2022-03-18 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 4:44 Tom Tromey
2022-03-18 16:00 ` Pedro Alves
2022-03-18 16:58 ` Tom Tromey [this message]
2022-03-28 21:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilsbfb97.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).