[obv. PATCH 1/1] Fix build breakage

[obv. PATCH 1/1] Fix build breakage

[Walfred Tedeschi]

Add a cast to reinterpret a void* as a gdb_byte*.

2016-02-09  Walfred Tedeschi  <walfred.tedeschi@intel.com>

gdb/gdbserver/ChangeLog:

        * linux-x86-low.c (x86_siginfo_fixup): Add cast to gdb_byte*.

---
 gdb/gdbserver/linux-x86-low.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/gdbserver/linux-x86-low.c b/gdb/gdbserver/linux-x86-low.c
index ff51a95..f32bd5d 100644
--- a/gdb/gdbserver/linux-x86-low.c
+++ b/gdb/gdbserver/linux-x86-low.c
@@ -690,12 +690,12 @@ x86_siginfo_fixup (siginfo_t *native, void *inf, int direction)
 
   /* Is the inferior 32-bit?  If so, then fixup the siginfo object.  */
   if (!is_64bit_tdesc ())
-      return amd64_linux_siginfo_fixup_common (native, inf, direction,
-					       FIXUP_32);
+      return amd64_linux_siginfo_fixup_common (native, (gdb_byte *) inf,
+					       direction, FIXUP_32);
   /* No fixup for native x32 GDB.  */
   else if (!is_elf64 && sizeof (void *) == 8)
-    return amd64_linux_siginfo_fixup_common (native, inf, direction,
-					     FIXUP_X32);
+    return amd64_linux_siginfo_fixup_common (native, (gdb_byte *) inf,
+					     direction, FIXUP_X32);
 #endif
 
   return 0;
-- 
2.1.4

Re: [obv. PATCH 1/1] Fix build breakage

[Pedro Alves]

On 02/09/2016 10:24 AM, Walfred Tedeschi wrote:
> Add a cast to reinterpret a void* as a gdb_byte*.
> 
> 2016-02-09  Walfred Tedeschi  <walfred.tedeschi@intel.com>
> 
> gdb/gdbserver/ChangeLog:
> 
>         * linux-x86-low.c (x86_siginfo_fixup): Add cast to gdb_byte*.
> 

How is this better than what Simon proposed?

Thanks,
Pedro Alves

RE: [obv. PATCH 1/1] Fix build breakage

[Tedeschi, Walfred]

-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
Sent: Tuesday, February 09, 2016 11:31 AM
To: Tedeschi, Walfred; eliz@gnu.org; brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [obv. PATCH 1/1] Fix build breakage

On 02/09/2016 10:24 AM, Walfred Tedeschi wrote:
> Add a cast to reinterpret a void* as a gdb_byte*.
> 
> 2016-02-09  Walfred Tedeschi  <walfred.tedeschi@intel.com>
> 
> gdb/gdbserver/ChangeLog:
> 
>         * linux-x86-low.c (x86_siginfo_fixup): Add cast to gdb_byte*.
> 

How is this better than what Simon proposed?

Thanks,
Pedro Alves

Pedro,

I haven't seem Simon's proposal, have just feel sorry to have caused this breakage, and tried to fix.
Just noticed that with the e-mail from Sergio this early morning.

I will revert what I just pushed,
-Fred

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [obv. PATCH 1/1] Fix build breakage

[Pedro Alves]

On 02/09/2016 10:37 AM, Tedeschi, Walfred wrote:
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves

> How is this better than what Simon proposed?

> I haven't seem Simon's proposal, have just feel sorry to have caused this breakage, and tried to fix.
> Just noticed that with the e-mail from Sergio this early morning.

Simon's fix was quoted in Sergio's e-mail.  :-)

> I will revert what I just pushed,

You reverted one patch unrelated patch too:

commit 0635c8759326e9431604b3359185cbf96740521d
Author:     Walfred Tedeschi <walfred.tedeschi@intel.com>

    Revert "Add a more helpful warning message to explain why some AArch64 relocations can overflow."

    This reverts commit 2ea53e003163338a403d5afbb2046cafb8f3abe9.

I've reapplied 2ea53e003163 now, preserving the original author (for "git blame").


BTW, given you first fixed the C++ build, and then broke it again with
the revert, you should have gotten another e-mail from the buildbot
about C++ build breakage.  Can you confirm whether you got one this time?

Thanks,
Pedro Alves

Re: [obv. PATCH 1/1] Fix build breakage

[Pedro Alves]

On 02/09/2016 10:49 AM, Pedro Alves wrote:
> On 02/09/2016 10:37 AM, Tedeschi, Walfred wrote:
>> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
> 
>> How is this better than what Simon proposed?
> 
>> I haven't seem Simon's proposal, have just feel sorry to have caused this breakage, and tried to fix.
>> Just noticed that with the e-mail from Sergio this early morning.
> 
> Simon's fix was quoted in Sergio's e-mail.  :-)
> 
>> I will revert what I just pushed,
> 
> You reverted one patch unrelated patch too:
> 
> commit 0635c8759326e9431604b3359185cbf96740521d
> Author:     Walfred Tedeschi <walfred.tedeschi@intel.com>
> 
>     Revert "Add a more helpful warning message to explain why some AArch64 relocations can overflow."
> 
>     This reverts commit 2ea53e003163338a403d5afbb2046cafb8f3abe9.
> 
> I've reapplied 2ea53e003163 now, preserving the original author (for "git blame").
> 
> 
> BTW, given you first fixed the C++ build, and then broke it again with
> the revert, you should have gotten another e-mail from the buildbot
> about C++ build breakage.  Can you confirm whether you got one this time?

Actually, the builder hasn't moved on past your reversion, we'll need to
wait a few minutes more to check that.

http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64

Pending Build Requests:
  (Feb 09 05:39:21, waiting 13 mins, 5 secs) c23bbc1cdae6... (Walfred Tedeschi <walfred.tedeschi@intel.com>)

Thanks,
Pedro Alves

Re: [obv. PATCH 1/1] Fix build breakage

[Walfred Tedeschi]

Am 2/9/2016 um 11:55 AM schrieb :
>
>
> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Tuesday, February 09, 2016 11:50 AM
> To: Tedeschi, Walfred
> Cc: gdb-patches@sourceware.org
> Subject: Re: [obv. PATCH 1/1] Fix build breakage
>
> On 02/09/2016 10:37 AM, Tedeschi, Walfred wrote:
>> From: gdb-patches-owner@sourceware.org
>> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
>
>> How is this better than what Simon proposed?
>
>> I haven't seem Simon's proposal, have just feel sorry to have caused this breakage, and tried to fix.
>> Just noticed that with the e-mail from Sergio this early morning.
>
> Simon's fix was quoted in Sergio's e-mail.  :-)
>
>> I will revert what I just pushed,
>
> You reverted one patch unrelated patch too:
>
> commit 0635c8759326e9431604b3359185cbf96740521d
> Author:     Walfred Tedeschi <walfred.tedeschi@intel.com>
>
>      Revert "Add a more helpful warning message to explain why some AArch64 relocations can overflow."
>
>      This reverts commit 2ea53e003163338a403d5afbb2046cafb8f3abe9.
>
> I've reapplied 2ea53e003163 now, preserving the original author (for "git blame").
>
>
> BTW, given you first fixed the C++ build, and then broke it again with the revert, you should have gotten another e-mail from the buildbot about C++ build breakage.  Can you confirm whether you got one this time?
>
> Thanks,
> Pedro Alves
>
> Pedro,
>
> I did not get the e-mail fro build bot again. :(
>
>

Pedro and All,

Sergio's email to me did not noted that, only the one reporting the 
status of the branching.  I saw about the same time i saw your e-mail.
See below:
https://sourceware.org/ml/gdb-patches/2016-02/msg00209.html


I will keep an eye on and inform you at end of the day. But looks like i 
do not get more e-mails from build bot. :|


Is there a web-page that you can follow the builds for a specific commit?

Sorry again for the inconvenience,
-Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [obv. PATCH 1/1] Fix build breakage

[Pedro Alves]

On 02/09/2016 11:05 AM, Walfred Tedeschi wrote:

> Is there a web-page that you can follow the builds for a specific commit?

There's http://gdb-build.sergiodj.net/grid

You can also follow the gdb-testers list, though its a bit too noisy ATM.

The commit thread was here:
  https://sourceware.org/ml/gdb-testers/2016-q1/msg03975.html

And the build breakage here:
  https://sourceware.org/ml/gdb-testers/2016-q1/msg03983.html

Thanks,
Pedro Alves

Re: [obv. PATCH 1/1] Fix build breakage

[Walfred Tedeschi]

Am 2/9/2016 um 12:13 PM schrieb Pedro Alves:
> On 02/09/2016 11:05 AM, Walfred Tedeschi wrote:
>
>> Is there a web-page that you can follow the builds for a specific commit?
>
> There's http://gdb-build.sergiodj.net/grid
>
> You can also follow the gdb-testers list, though its a bit too noisy ATM.
>
> The commit thread was here:
>    https://sourceware.org/ml/gdb-testers/2016-q1/msg03975.html
>
> And the build breakage here:
>    https://sourceware.org/ml/gdb-testers/2016-q1/msg03983.html
>
> Thanks,
> Pedro Alves
>

Pedro,

Thanks for the info.

I did not get any e-mail from buildbot till now, i am subscribing for 
the gdb-testers list so i can keep informed anyway.

Thanks again!

-Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [obv. PATCH 1/1] Fix build breakage

[Pedro Alves]

On 02/09/2016 01:50 PM, Walfred Tedeschi wrote:

> I did not get any e-mail from buildbot till now, i am subscribing for 
> the gdb-testers list so i can keep informed anyway.

Odd.  You should have gotten one by now, as the build slave as already
failed building the reversion commit, and it succeeded the build in
the commit before that one:

 http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1898
 http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1897

Any chance the email is in some spam folder in your mail client?

Sergio, is there any way to check if the email was sent from the buildbot side?

Thanks,
Pedro Alves

Re: [obv. PATCH 1/1] Fix build breakage

[Walfred Tedeschi]

Am 2/9/2016 um 3:11 PM schrieb Pedro Alves:
> On 02/09/2016 01:50 PM, Walfred Tedeschi wrote:
>
>> I did not get any e-mail from buildbot till now, i am subscribing for
>> the gdb-testers list so i can keep informed anyway.
>
> Odd.  You should have gotten one by now, as the build slave as already
> failed building the reversion commit, and it succeeded the build in
> the commit before that one:
>
>   http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1898
>   http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1897
>
> Any chance the email is in some spam folder in your mail client?
>
> Sergio, is there any way to check if the email was sent from the buildbot side?
>
> Thanks,
> Pedro Alves
>

Pedro,

Not in any of my folder, perhaps filtered in another level.
And today I could only see that via the gdb-testers also today I 
received no e-mail.

I am going keep an eye on builds via the gdb-testers when committing.

Best regards and thanks a lot,
-Fred





Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [obv. PATCH 1/1] Fix build breakage

[Sergio Durigan Junior]

On Tuesday, February 09 2016, Pedro Alves wrote:

> On 02/09/2016 01:50 PM, Walfred Tedeschi wrote:
>
>> I did not get any e-mail from buildbot till now, i am subscribing for 
>> the gdb-testers list so i can keep informed anyway.
>
> Odd.  You should have gotten one by now, as the build slave as already
> failed building the reversion commit, and it succeeded the build in
> the commit before that one:
>
>  http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1898
>  http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1897
>
> Any chance the email is in some spam folder in your mail client?
>
> Sergio, is there any way to check if the email was sent from the buildbot side?

That's strange, indeed.  I wasn't able to confirm whether the message
was sent or not.  Walfred, maybe Pedro is right and the message is in
your spam folder?  If it is not, please let me know and I'll take a
closer look.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

RE: [obv. PATCH 1/1] Fix build breakage

[Tedeschi, Walfred]

-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Sergio Durigan Junior
Sent: Tuesday, February 09, 2016 7:24 PM
To: Pedro Alves
Cc: Tedeschi, Walfred; gdb-patches@sourceware.org
Subject: Re: [obv. PATCH 1/1] Fix build breakage

On Tuesday, February 09 2016, Pedro Alves wrote:

> On 02/09/2016 01:50 PM, Walfred Tedeschi wrote:
>
>> I did not get any e-mail from buildbot till now, i am subscribing for 
>> the gdb-testers list so i can keep informed anyway.
>
> Odd.  You should have gotten one by now, as the build slave as already 
> failed building the reversion commit, and it succeeded the build in 
> the commit before that one:
>
>  
> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/bui
> lds/1898
>  
> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/bui
> lds/1897
>
> Any chance the email is in some spam folder in your mail client?
>
> Sergio, is there any way to check if the email was sent from the buildbot side?

That's strange, indeed.  I wasn't able to confirm whether the message was sent or not.  Walfred, maybe Pedro is right and the message is in your spam folder?  If it is not, please let me know and I'll take a closer look.

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/


Sergio,

I haven't received any e-mail as far as I could see, looked for the link in all folders.
 
In any case I am going to ask IT if they also have some kind of additional filtering, will keep you posted on that.

Thanks and regards,
-Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928