[PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well

[PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well

[Aditya Vidyadhar Kamath]

From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>

This patch is to make this testcase run on AIX.

---
 gdb/testsuite/gdb.threads/thread_events.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.threads/thread_events.exp b/gdb/testsuite/gdb.threads/thread_events.exp
index 100205e5f58..9c3f9ce1708 100644
--- a/gdb/testsuite/gdb.threads/thread_events.exp
+++ b/gdb/testsuite/gdb.threads/thread_events.exp
@@ -21,9 +21,9 @@
 # messages are printed and can be disabled) is dependent on the target
 # thread support code.
 
-# This test has only been verified with Linux targets, and would need
+# This test has been verified with Linux targets and AIX target, and would need
 # to be generalized to support other targets
-if {![istarget *-*-linux*]} {
+if {!([istarget *-*-linux*] || [istarget *-*-aix*])} {
     return
 }
 
-- 
2.41.0

Re: [PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well

[Aditya Kamath1]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

Respected community members,

This patch is a version 2 of the test case change to run on AIX.

Can someone kindly push this patch.

>Could you update the comment to indicate that it's been verified to
>work with (both) Linux and AIX targets?
>Once that's done, you have my approval:
>Approved-by: Kevin Buettner <kevinb@redhat.com<mailto:kevinb@redhat.com>>

I have updated this.

Have a nice day ahead.

Thanks and regards,
Aditya.

From: Aditya Vidyadhar Kamath <akamath996@gmail.com>
Date: Thursday, 2 May 2024 at 7:54 PM
To: tom@tromey.com <tom@tromey.com>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, gdb-patches@sourceware.org <gdb-patches@sourceware.org>, Aditya Kamath1 <Aditya.Kamath1@ibm.com>, Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>, Kevin Buettner <kevinb@redhat.com>
Subject: [EXTERNAL] [PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well
From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>

This patch is to make this testcase run on AIX.

---
 gdb/testsuite/gdb.threads/thread_events.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.threads/thread_events.exp b/gdb/testsuite/gdb.threads/thread_events.exp
index 100205e5f58..9c3f9ce1708 100644
--- a/gdb/testsuite/gdb.threads/thread_events.exp
+++ b/gdb/testsuite/gdb.threads/thread_events.exp
@@ -21,9 +21,9 @@
 # messages are printed and can be disabled) is dependent on the target
 # thread support code.

-# This test has only been verified with Linux targets, and would need
+# This test has been verified with Linux targets and AIX target, and would need
 # to be generalized to support other targets
-if {![istarget *-*-linux*]} {
+if {!([istarget *-*-linux*] || [istarget *-*-aix*])} {
     return
 }

--
2.41.0

Re: [PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well

[Tom Tromey]

>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

> From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>
> This patch is to make this testcase run on AIX.

Does it work with the current tree?  Or does it require your other patch
to land first?

If it does require the other patch, it should just be part of that
patch.

Also I wonder why this test checks istarget by hand rather than using
require.

Tom

Re: [PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well

[Kevin Buettner]

On Thu, 2 May 2024 14:28:27 +0000
Aditya Kamath1 <Aditya.Kamath1@ibm.com> wrote:

> This patch is a version 2 of the test case change to run on AIX.
> 
> Can someone kindly push this patch.

After reading Tom's reply, I'd like to see 'require' used instead of
the old way of doing things.  I think the require line will look like
this:

require {is_any_target "*-*-linux*" "*-*-aix*"}

Kevin

RE: [PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well

[Aditya Kamath1]

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

Respected Tom and community members,

Hi,


>Does it work with the current tree?  Or does it require your other patch
>to land first?

>If it does require the other patch, it should just be part of that
>patch.

No it does work with the current tree. Yes, we need the other patch to land first for it to pass all the tests in this testcase. Currently, if the other patch is not committed we will have failures. Sure, I will add this in the other patch part of v4.

>Also I wonder why this test checks istarget by hand rather than using
>require.

I ll add requires as well.

Thanks and regards,
Aditya
From: Tom Tromey <tom@tromey.com>
Date: Thursday, 2 May 2024 at 9:52 PM
To: Aditya Vidyadhar Kamath <akamath996@gmail.com>
Cc: tom@tromey.com <tom@tromey.com>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, gdb-patches@sourceware.org <gdb-patches@sourceware.org>, Aditya Kamath1 <Aditya.Kamath1@ibm.com>, Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>, Kevin Buettner <kevinb@redhat.com>
Subject: [EXTERNAL] Re: [PATCH v2] Add gdb.threads/thread_events.exp to run in AIX as well
>>>>> Aditya Vidyadhar Kamath <akamath996@gmail.com> writes:

> From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>
> This patch is to make this testcase run on AIX.

Does it work with the current tree?  Or does it require your other patch
to land first?

If it does require the other patch, it should just be part of that
patch.

Also I wonder why this test checks istarget by hand rather than using
require.

Tom