From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix two serious flake8 reports
Date: Tue, 19 Mar 2024 10:06:48 -0600 [thread overview]
Message-ID: <87jzlygq93.fsf@tromey.com> (raw)
In-Reply-To: <20240223190641.3662803-1-tromey@adacore.com> (Tom Tromey's message of "Fri, 23 Feb 2024 12:06:41 -0700")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> flake8 points out that some code in frame_filters.py is referring to
Tom> undefined variables.
Tom> In the first hunk, I've changed the code to match what other
Tom> 'complete' methods do in this file.
Tom> In the second hunk, I've simply removed the try/except -- if
Tom> get_filter_priority fails, it will raise GdbError, which is already
Tom> handled properly by gdb.
I'm checking this in.
flake8 has pointed out some new errors, I'll send another fix for those.
Tom
prev parent reply other threads:[~2024-03-19 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 19:06 Tom Tromey
2024-03-19 16:06 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzlygq93.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).